> The API specification for descriptorString not being a strict inverse of 
> Class::forName and MethodType::fromDescriptorString are not entirely correct.
> 
> 1. Class::descriptorString was never an inverse of Class::forName, which 
> takes a binary name instead. The note about different class loaders is moved 
> to getName, as ClassDesc requires an explicit lookup for resolution already.
> 2. MethodType::toMethodDescriptorString ends with a meaningless sentence: 
> "fromMethodDescriptorString, because the latter requires a suitable class 
> loader argument.", and the "Note:" section can be replaced with an `@apiNote`.
> 3. Both of these didn't mention hidden classes (or other 
> non-nominally-describable classes) as a reason that prevents the inversion 
> operation, in addition to distinct class loaders. Added valid method type 
> descriptor/binary name as a prerequisite for the distinct class loader 
> explanation.
> 
> A few user-defined anchor links are replaced with updated javadoc link tag 
> format as well. The explicit html-style links in `@see` tags are unchanged in 
> order to retain the non-code output.
> 
> The rendered specifications:
> https://cr.openjdk.org/~liach/8309819/06/java.base/java/lang/Class.html
> https://cr.openjdk.org/~liach/8309819/06/java.base/java/lang/invoke/MethodType.html

Chen Liang has updated the pull request incrementally with one additional 
commit since the last revision:

  Reword of the distinct-class-same-descriptor note

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14411/files
  - new: https://git.openjdk.org/jdk/pull/14411/files/be3e8cd3..96b142e0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14411&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14411&range=06-07

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/14411.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14411/head:pull/14411

PR: https://git.openjdk.org/jdk/pull/14411

Reply via email to