On Wed, 28 Jun 2023 17:46:51 GMT, Roger Riggs wrote:
>> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
>> If the `compareInstant` utility method returns 0 (equal), it compares the
>> `LocalDateTime`.
>> However, `compareInstant` has already done that comparison; if it
On Wed, 28 Jun 2023 19:35:27 GMT, Naoto Sato wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reopen to work on an improved fix
>> Add a test for the specific condition being optimized, the test was
>> missing in
On Wed, 28 Jun 2023 17:46:51 GMT, Roger Riggs wrote:
>> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
>> If the `compareInstant` utility method returns 0 (equal), it compares the
>> `LocalDateTime`.
>> However, `compareInstant` has already done that comparison; if it
On Thu, 22 Jun 2023 19:03:03 GMT, Roger Riggs wrote:
> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
> If the `compareInstant` utility method returns 0 (equal), it compares the
> `LocalDateTime`.
> However, `compareInstant` has already done that comparison; if it
On Mon, 26 Jun 2023 18:28:47 GMT, Naoto Sato wrote:
>> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
>> If the `compareInstant` utility method returns 0 (equal), it compares the
>> `LocalDateTime`.
>> However, `compareInstant` has already done that comparison; if it
On Thu, 22 Jun 2023 19:03:03 GMT, Roger Riggs wrote:
> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
> If the `compareInstant` utility method returns 0 (equal), it compares the
> `LocalDateTime`.
> However, `compareInstant` has already done that comparison; if it
On Thu, 22 Jun 2023 19:03:03 GMT, Roger Riggs wrote:
> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
> If the `compareInstant` utility method returns 0 (equal), it compares the
> `LocalDateTime`.
> However, `compareInstant` has already done that comparison; if it
Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
If the `compareInstant` utility method returns 0 (equal), it compares the
`LocalDateTime`.
However, `compareInstant` has already done that comparison; if it found equal,
the `compareTo` method unnecessarily does it again.