Re: RFR: 8310405: Linker.Option.firstVariadicArg should specify which index values are valid [v2]

2023-06-23 Thread Maurizio Cimadamore
On Fri, 23 Jun 2023 17:24:30 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> polish doc, review comments > > src/java.base/share/classes/java/lang/foreign/Linker.java line 659: > >> 657:

Re: RFR: 8310405: Linker.Option.firstVariadicArg should specify which index values are valid [v2]

2023-06-23 Thread Maurizio Cimadamore
On Wed, 21 Jun 2023 23:33:37 GMT, Jorn Vernee wrote: >> Improve the specification of `Linker.Option.firstVariadicArg`, by specifying >> more clearly which index values are valid. > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8310405: Linker.Option.firstVariadicArg should specify which index values are valid [v2]

2023-06-21 Thread Jorn Vernee
On Wed, 21 Jun 2023 07:34:20 GMT, Per Minborg wrote: >> Possible suggestion/thing to try: use a bullet list to spell out all cases >> for `index`. E.g. we know there's index == 0 (all variadic). Then we know >> there's index = N (no variadic). Then there's index == m, 0 < m < N - which >>

Re: RFR: 8310405: Linker.Option.firstVariadicArg should specify which index values are valid [v2]

2023-06-21 Thread Jorn Vernee
> Improve the specification of `Linker.Option.firstVariadicArg`, by specifying > more clearly which index values are valid. Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: polish doc, review comments - Changes: - all: