Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-10 Thread Daniel Fuchs
On Mon, 10 Jul 2023 05:05:13 GMT, Alan Bateman wrote: >> Docs only update to add a missing `@throws StructureViolationException` and >> make it clearer when the exception is thrown. In the future we might >> re-visit this so that the description is in one place rather than in each >> method.

Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-10 Thread Jaikiran Pai
On Mon, 10 Jul 2023 06:13:02 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/lang/ScopedValue.java line 405: >> >>> 403: * as a structure violation when the operation >>> completes (normally or with an >>> 404: * exception). In that case, the underlying construct

Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-10 Thread Jaikiran Pai
On Mon, 10 Jul 2023 05:05:13 GMT, Alan Bateman wrote: >> Docs only update to add a missing `@throws StructureViolationException` and >> make it clearer when the exception is thrown. In the future we might >> re-visit this so that the description is in one place rather than in each >> method.

Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-10 Thread Alan Bateman
On Mon, 10 Jul 2023 06:04:57 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-10 Thread Jaikiran Pai
On Mon, 10 Jul 2023 05:05:13 GMT, Alan Bateman wrote: >> Docs only update to add a missing `@throws StructureViolationException` and >> make it clearer when the exception is thrown. In the future we might >> re-visit this so that the description is in one place rather than in each >> method.

Re: RFR: 8310892: ScopedValue throwing StructureViolationException should be clearer [v3]

2023-07-09 Thread Alan Bateman
> Docs only update to add a missing `@throws StructureViolationException` and > make it clearer when the exception is thrown. In the future we might re-visit > this so that the description is in one place rather than in each method. Alan Bateman has updated the pull request with a new target