Re: RFR: 8310999: Add @since info in jdk.jsobject files [v2]

2023-07-05 Thread Phil Race
On Wed, 5 Jul 2023 16:20:07 GMT, Roger Riggs wrote: >> Source code cleanup. >> Add @since, remove unused imports and remove unnecessary SuppressWarnings of >> deprecation. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Rem

Re: RFR: 8310999: Add @since info in jdk.jsobject files [v2]

2023-07-05 Thread Roger Riggs
> Source code cleanup. > Add @since, remove unused imports and remove unnecessary SuppressWarnings of > deprecation. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Remove unneeded @SuppressWarnings - Changes: - all: h

Re: RFR: 8310999: Add @since info in jdk.jsobject files [v2]

2023-07-05 Thread Roger Riggs
On Wed, 5 Jul 2023 16:05:25 GMT, Phil Race wrote: > unless my eyes deceive me the suppresswarnings is still present. Gack!, I removed it and then put it back to try to discover why it was there in the first place. Gone again and thanks - PR Comment: https://git.openjdk.org/jdk/pul

Re: RFR: 8310999: Add @since info in jdk.jsobject files [v2]

2023-07-05 Thread Iris Clark
On Wed, 5 Jul 2023 16:20:07 GMT, Roger Riggs wrote: >> Source code cleanup. >> Add @since, remove unused imports and remove unnecessary SuppressWarnings of >> deprecation. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Rem

Re: RFR: 8310999: Add @since info in jdk.jsobject files

2023-07-05 Thread Phil Race
On Wed, 5 Jul 2023 14:51:31 GMT, Roger Riggs wrote: > Source code cleanup. > Add @since, remove unused imports and remove unnecessary SuppressWarnings of > deprecation. unless my eyes deceive me the suppresswarnings is still present. - Changes requested by prr (Reviewer). PR Revi

Re: RFR: 8310999: Add @since info in jdk.jsobject files

2023-07-05 Thread Iris Clark
On Wed, 5 Jul 2023 14:51:31 GMT, Roger Riggs wrote: > Source code cleanup. > Add @since, remove unused imports and remove unnecessary SuppressWarnings of > deprecation. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14775#pullrequestreview-151

Re: RFR: 8310999: Add @since info in jdk.jsobject files

2023-07-05 Thread Brian Burkhalter
On Wed, 5 Jul 2023 14:51:31 GMT, Roger Riggs wrote: > Source code cleanup. > Add @since, remove unused imports and remove unnecessary SuppressWarnings of > deprecation. Marked as reviewed by bpb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14775#pullrequestreview-1514

Re: RFR: 8310999: Add @since info in jdk.jsobject files

2023-07-05 Thread Joe Wang
On Wed, 5 Jul 2023 14:51:31 GMT, Roger Riggs wrote: > Source code cleanup. > Add @since, remove unused imports and remove unnecessary SuppressWarnings of > deprecation. Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14775#pullrequestreview-15

Re: RFR: 8310999: Add @since info in jdk.jsobject files

2023-07-05 Thread Lance Andersen
On Wed, 5 Jul 2023 14:51:31 GMT, Roger Riggs wrote: > Source code cleanup. > Add @since, remove unused imports and remove unnecessary SuppressWarnings of > deprecation. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14775#pullrequestreview-1

RFR: 8310999: Add @since info in jdk.jsobject files

2023-07-05 Thread Roger Riggs
Source code cleanup. Add @since, remove unused imports and remove unnecessary SuppressWarnings of deprecation. - Commit messages: - 8310999: Add @since info in jdk.jsobject files Changes: https://git.openjdk.org/jdk/pull/14775/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr