Re: RFR: 8311104: dangling-gsl warning in libwixhelper.cpp

2023-07-26 Thread Alexander Matveev
On Wed, 26 Jul 2023 18:42:47 GMT, Alexey Semenyuk wrote: > 8311104: dangling-gsl warning in libwixhelper.cpp Looks good. - Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15044#pullrequestreview-1548666131

Re: RFR: 8311104: dangling-gsl warning in libwixhelper.cpp

2023-07-26 Thread Alexey Semenyuk
On Wed, 26 Jul 2023 20:05:11 GMT, Alexander Matveev wrote: >> 8311104: dangling-gsl warning in libwixhelper.cpp > > src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp line 75: > >> 73: void findInstalledProducts(const Guid& upgradeCode, >> 74:

Re: RFR: 8311104: dangling-gsl warning in libwixhelper.cpp

2023-07-26 Thread Alexander Matveev
On Wed, 26 Jul 2023 18:42:47 GMT, Alexey Semenyuk wrote: > 8311104: dangling-gsl warning in libwixhelper.cpp src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp line 75: > 73: void findInstalledProducts(const Guid& upgradeCode, > 74:

Re: RFR: 8311104: dangling-gsl warning in libwixhelper.cpp

2023-07-26 Thread Alexey Semenyuk
On Wed, 26 Jul 2023 18:42:47 GMT, Alexey Semenyuk wrote: > 8311104: dangling-gsl warning in libwixhelper.cpp @sashamatveev please review - PR Comment: https://git.openjdk.org/jdk/pull/15044#issuecomment-1652324135

RFR: 8311104: dangling-gsl warning in libwixhelper.cpp

2023-07-26 Thread Alexey Semenyuk
8311104: dangling-gsl warning in libwixhelper.cpp - Commit messages: - 8311104: dangling-gsl warning in libwixhelper.cpp Changes: https://git.openjdk.org/jdk/pull/15044/files Webrev: https://webrevs.openjdk.org/?repo=jdk=15044=00 Issue: