> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` > CLI options to jpackage to provide signing identity directly to `codesign` > and `productbuild` tools as per CSR > [JDK-8316631](https://bugs.openjdk.org/browse/JDK-8316631). > - If `codesign` or `productbuild` fails, then output of these tools will be > printed to stdout to help user diagnose issues with signing using new > options. Examples with sign identity set to "test" which does not exist on > system: >> Error: "codesign" failed with following output: >> test: no identity found > >> Error: "productbuild" failed with following output: >> productbuild: error: Cannot write product to "/Users/SOMEDIR/Test-1.0.pkg". >> (Could not find appropriate signing identity for “test”.) > - Added error handling not to allow invalid combinations of signing options. > - Updated signing tests to test new changes.
Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into JDK-8311877 - 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild ------------- Changes: - all: https://git.openjdk.org/jdk/pull/16085/files - new: https://git.openjdk.org/jdk/pull/16085/files/57abfbad..4cd56e25 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16085&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16085&range=00-01 Stats: 42104 lines in 1446 files changed: 26275 ins; 7631 del; 8198 mod Patch: https://git.openjdk.org/jdk/pull/16085.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16085/head:pull/16085 PR: https://git.openjdk.org/jdk/pull/16085
