Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

2023-08-15 Thread Ian Graves
On Thu, 3 Aug 2023 12:34:19 GMT, Raffaello Giulietti wrote: >> Cristian Vat has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changes and test for CIBackRef > > The change looks good. > However, I'm not a Reviewer. This looks good to

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

2023-08-03 Thread Raffaello Giulietti
On Fri, 28 Jul 2023 12:15:21 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

2023-07-28 Thread Cristian Vat
On Fri, 28 Jul 2023 12:15:21 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

2023-07-28 Thread Cristian Vat
> Reduces excessive allocation of Matcher.groups array when the original > Pattern has no groups or less than 9 groups. > > Original clamping to 10 possibly due to documented behavior from javadoc: > "In this class, \1 through \9 are always interpreted as back references, " > > Only with