Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-18 Thread Ron Pressler
On Thu, 14 Sep 2023 13:30:28 GMT, Alan Bateman wrote: >> Thread::getState is an API for monitoring and management purposes to report >> the thread state. If a virtual thread is parked with LockSupport.parkNanos, >> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI >>

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-17 Thread Alan Bateman
On Mon, 18 Sep 2023 01:44:10 GMT, David Holmes wrote: > Surely that is not a specified exported thread state though ?? Why would we > care about PINNED (timed or otherwise) in the current context? There are internal states and then mappings to the thread states defined by the APIs

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-17 Thread David Holmes
On Fri, 15 Sep 2023 06:34:52 GMT, Alan Bateman wrote: >> What is TIMED PINNING? >> >> To me TIMED_X are a specific set of states and there are not enough of them >> to consider TIMED to be a bit that can be applied to any state X. > >> What is TIMED PINNING? > > LockSupport.parkNanos when

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-15 Thread Alan Bateman
On Fri, 15 Sep 2023 00:36:10 GMT, David Holmes wrote: > What is TIMED PINNING? LockSupport.parkNanos when the carrier can't be released due to monitor or native frame. - PR Review Comment: https://git.openjdk.org/jdk/pull/14978#discussion_r1326860516

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread David Holmes
On Thu, 14 Sep 2023 13:29:48 GMT, Alan Bateman wrote: >> Yes but TIMED and SUSPENDED are not alike. I assume SUSPENDED is a >> stand-alone bit because you can be in various states and suspended at the >> same time. But TIMED isn't like that. > >> Yes but TIMED and SUSPENDED are not alike. I

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread Alan Bateman
On Thu, 27 Jul 2023 01:54:58 GMT, Serguei Spitsyn wrote: > Looks good. > Thanks, > Serguei Thanks Serguei. I had to pause this to work on other things. When I sync'ed up the branch I found I had to update recently introduced test jvmti/vthread/VThreadEventTest/VThreadEventTest.java as it was

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread Alan Bateman
On Wed, 26 Jul 2023 12:18:02 GMT, David Holmes wrote: > Yes but TIMED and SUSPENDED are not alike. I assume SUSPENDED is a > stand-alone bit because you can be in various states and suspended at the > same time. But TIMED isn't like that. The SUSPENDED bit can only be set when the virtual

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread Alan Bateman
> Thread::getState is an API for monitoring and management purposes to report > the thread state. If a virtual thread is parked with LockSupport.parkNanos, > its state is reported as WAITING when it should be TIMED_WAITING. JVM TI > GetThreadState has the same issue in that it returns >