Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

2023-09-26 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

2023-09-27 Thread Alan Bateman
On Wed, 27 Sep 2023 00:53:25 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

2023-09-27 Thread Jorn Vernee
On Wed, 27 Sep 2023 14:50:32 GMT, Alan Bateman wrote: >> Jorn Vernee has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix visibility issues >> >>Reviewed-by: mcimadamore >> - Review comments > > test/hotspot/jtreg/compiler/rang

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

2023-09-27 Thread Alan Bateman
On Wed, 27 Sep 2023 00:53:25 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

2023-09-27 Thread Jorn Vernee
On Wed, 27 Sep 2023 15:04:12 GMT, Alan Bateman wrote: >> Jorn Vernee has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix visibility issues >> >>Reviewed-by: mcimadamore >> - Review comments > > src/java.base/share/classes/java

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

2023-09-27 Thread Alan Bateman
On Wed, 27 Sep 2023 16:12:46 GMT, Jorn Vernee wrote: > Side note: I don't believe I have to add all the different error message > translations right? Only the English version? That's right, the translations will be updated towards the end of the release. - PR Review Comment: https

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v28]

2023-09-27 Thread Jorn Vernee
On Wed, 27 Sep 2023 14:52:52 GMT, Jorn Vernee wrote: >> test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckHoistingScaledIV.java >> line 32: >> >>> 30: * @modules jdk.incubator.vector >>> 31: * @compile -source ${jdk.version} TestRangeCheckHoistingScaledIV.java >>> 32: * @run main/othervm