On Tue, 2 Jan 2024 10:37:55 GMT, Jaikiran Pai wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Prevent IOException thrown during finish() from being lost if an
>> IOException is thrown while closing the wrapped s
On Tue, 2 Jan 2024 09:14:14 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which makes `DeflaterOutputStream.close()` always
>> close its wrapped output stream.
>>
>> Currently, closing of the wrapped output stream happens outside the finally
>> block where `finish()` is called. If `fin
On Tue, 2 Jan 2024 08:35:47 GMT, Jaikiran Pai wrote:
> This call has a potential to throw an `IOException` in which case any
> original `IOException` thrown from the `finish()` call will be lost.
Good catch. Adopted your suggestion with a few changes:
- The catch for IOException during finish(
> Please consider this PR which makes `DeflaterOutputStream.close()` always
> close its wrapped output stream.
>
> Currently, closing of the wrapped output stream happens outside the finally
> block where `finish()` is called. If `finish()` throws, this means the
> wrapped stream will not be cl
