Re: RFR: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute

2023-09-01 Thread Adam Sotona
On Thu, 31 Aug 2023 16:47:07 GMT, Mandy Chung wrote: > Would you consider documenting in the javadoc of XXXAttribute in the > ClassFile API if it allows multiple? It will make clear to the readers. Yes, I'll add that information as a part of javadoc update #14968. Thanks! - PR

Re: RFR: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute

2023-08-31 Thread Mandy Chung
On Thu, 31 Aug 2023 12:13:40 GMT, Adam Sotona wrote: > ModuleTarget and ModuleResolution attributes were flagged as 'allow multiple' > in the Classfile API. > This patch removed the flags and allows at most one instance of each > attribute. > > Please review. > > Thanks, > Adam Would you

Re: RFR: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute

2023-08-31 Thread Mandy Chung
On Thu, 31 Aug 2023 12:13:40 GMT, Adam Sotona wrote: > ModuleTarget and ModuleResolution attributes were flagged as 'allow multiple' > in the Classfile API. > This patch removed the flags and allows at most one instance of each > attribute. > > Please review. > > Thanks, > Adam Marked as

Re: RFR: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute

2023-08-31 Thread Alan Bateman
On Thu, 31 Aug 2023 12:13:40 GMT, Adam Sotona wrote: > ModuleTarget and ModuleResolution attributes were flagged as 'allow multiple' > in the Classfile API. > This patch removed the flags and allows at most one instance of each > attribute. > > Please review. > > Thanks, > Adam Thanks for

RFR: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute

2023-08-31 Thread Adam Sotona
ModuleTarget and ModuleResolution attributes were flagged as 'allow multiple' in the Classfile API. This patch removed the flags and allows at most one instance of each attribute. Please review. Thanks, Adam - Commit messages: - 8313983: jmod create --target-platform should