On Mon, 21 Aug 2023 21:36:13 GMT, David Holmes wrote:
>>> Nit: no need to pre-declare this, just use `int error = getJavaPath(...)`
>>
>> This one was intentional to keep the style consistent =)
>
> The others are more widely used and there is a desire to document their
> meaning. That isn't
On Mon, 21 Aug 2023 20:30:54 GMT, Vladimir Petko wrote:
>> src/java.base/unix/native/launcher/jexec.c line 162:
>>
>>> 160: int argi = 0; /* index into old array */
>>> 161: size_talen = 0; /* length of new array */
>>> 162: int
On Mon, 21 Aug 2023 07:59:35 GMT, David Holmes wrote:
> Nit: no need to pre-declare this, just use `int error = getJavaPath(...)`
This one was intentional to keep the style consistent =)
-
PR Review Comment: https://git.openjdk.org/jdk/pull/15343#discussion_r1300614894
On Mon, 21 Aug 2023 07:14:44 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment: use /proc/self/exe as the backup
On Mon, 21 Aug 2023 07:14:44 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment: use /proc/self/exe as the backup
> 8314491: Linux: jexec launched via PATH fails to find java
Vladimir Petko has updated the pull request incrementally with one additional
commit since the last revision:
Review comment: use /proc/self/exe as the backup option
-
Changes:
- all:
On Mon, 21 Aug 2023 06:33:50 GMT, David Holmes wrote:
> To minimise the impact on existing users can this be implemented as a
> fallback if the initial attempt to locate `java` fails?
Updated and re-run the affected test:
==
Test summary
