RFR: 8315444: Convert test/jdk/tools to Classfile API

2023-09-01 Thread Qing Xiao
/test/jdk/tools/lib/tests/JImageValidator.java, tests in /test/jdk/tools/jlink and /test/jdk/tools/jimage use on com.sun.tools.classfile and should be converted to Classfile API. - Commit messages: - migrate /test/jdk/tools/lib/tests/JImageValidator.java and tests in /test/jdk/too

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API

2023-09-01 Thread Adam Sotona
On Fri, 1 Sep 2023 08:14:26 GMT, Qing Xiao wrote: > /test/jdk/tools/lib/tests/JImageValidator.java, tests in > /test/jdk/tools/jlink and /test/jdk/tools/jimage use on > com.sun.tools.classfile and should be converted to Classfile API. It looks good, thanks. - PR Comment: https://

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API

2023-09-04 Thread Adam Sotona
On Fri, 1 Sep 2023 08:14:26 GMT, Qing Xiao wrote: > /test/jdk/tools/lib/tests/JImageValidator.java, tests in > /test/jdk/tools/jlink and /test/jdk/tools/jimage use on > com.sun.tools.classfile and should be converted to Classfile API. Following tier2 test is affected by the change and fails: t

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API [v2]

2023-09-05 Thread Qing Xiao
> /test/jdk/tools/lib/tests/JImageValidator.java, tests in > /test/jdk/tools/jlink and /test/jdk/tools/jimage use on > com.sun.tools.classfile and should be converted to Classfile API. Qing Xiao has updated the pull request incrementally with one additional commit since the last revision: mi

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API [v2]

2023-09-05 Thread Chen Liang
On Tue, 5 Sep 2023 16:05:14 GMT, Qing Xiao wrote: >> `/test/jdk/tools/lib/tests/JImageValidator.java`, tests in >> `/test/jdk/tools/jlink`, and `/test/jdk/tools/jimage`, >> `/test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java` use >> on com.sun.tools.classfile and should be co

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API [v2]

2023-09-06 Thread Adam Sotona
On Tue, 5 Sep 2023 23:33:05 GMT, Chen Liang wrote: >> Qing Xiao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> migrate >> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java use >> Classfile API > > test/jdk/tools/lib/

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API [v3]

2023-09-06 Thread Qing Xiao
> `/test/jdk/tools/lib/tests/JImageValidator.java`, tests in > `/test/jdk/tools/jlink`, and `/test/jdk/tools/jimage`, > `/test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java` use on > com.sun.tools.classfile and should be converted to Classfile API. Qing Xiao has updated the pul

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API [v3]

2023-09-07 Thread Adam Sotona
On Wed, 6 Sep 2023 16:44:15 GMT, Qing Xiao wrote: >> `/test/jdk/tools/lib/tests/JImageValidator.java`, tests in >> `/test/jdk/tools/jlink`, and `/test/jdk/tools/jimage`, >> `/test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java` use >> on com.sun.tools.classfile and should be co