Re: RFR: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing [v2]

2023-09-06 Thread Adam Sotona
On Wed, 6 Sep 2023 08:10:12 GMT, ExE Boss wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed tests > > src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPool.java > line 76: > >> 74:

Re: RFR: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing [v2]

2023-09-06 Thread ExE Boss
On Tue, 5 Sep 2023 15:25:04 GMT, Adam Sotona wrote: >> Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex` >> methods are confusing and unsafe to use without knowledge of constant pool >> specification. >> This patch renames `ConstantPool::entryCount` to

Re: RFR: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing [v2]

2023-09-05 Thread Adam Sotona
> Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex` > methods are confusing and unsafe to use without knowledge of constant pool > specification. > This patch renames `ConstantPool::entryCount` to `ConstantPool::size` and > adds checks to `ConstantPool::entryByIndex` for