On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10,
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10,
On Tue, 28 Nov 2023 20:41:21 GMT, Alan Bateman wrote:
> Doing it early in JDK 23 to allow time for course correction if needed seems
> a good plan.
Another benefit is that if we should decide to validate LOC headers similarly
in `ZipInputStream`, delaying until 23 will allow us to introduce
On Tue, 28 Nov 2023 20:06:25 GMT, Lance Andersen wrote:
> Given where we are in the JDK 22 cycle, going to hold off on finalizing the
> PR until we fork for JDK 23 and look to move this forward early on allowing
> for additional time to bake
Tightening validation always comes with risk. Doing
On Thu, 16 Nov 2023 20:52:08 GMT, Eirik Bjorsnos wrote:
> > Regarding you comment about checking whether or not to check if the
> > combined length of the CEN header + name length + comment length + extra
> > length > 65K bytes, I chose to add this given the strong wording given this
> > is a
On Thu, 9 Nov 2023 17:22:39 GMT, Lance Andersen wrote:
> Regarding you comment about checking whether or not to check if the combined
> length of the CEN header + name length + comment length + extra length > 65K
> bytes, I chose to add this given the strong wording given this is a really
>
On Wed, 8 Nov 2023 20:26:32 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which enhances the existing CEN header validation
>> checking to ensure that the
>> size of the CEN Header + name length + comment length + extra length do not
>> exceed 65,535 bytes per the PKWare APP.NOTE
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10,
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10,
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10,
Please review this PR which enhances the existing CEN header validation
checking to ensure that the
size of the CEN Header + name length + comment length + extra length do not
exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10, 4.4.11, & 4.4.12. Also
check that current CEN header will not
11 matches
Mail list logo
