Re: RFR: 8316190: Improve MemorySegment::toString

2023-09-14 Thread Claes Redestad
On Thu, 14 Sep 2023 13:44:59 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277: >> >>> 275: } >>> 276: >>> 277: public static String toHexString(long value) { >> >> We intend to use this utility method in coming PRs. > > The String concat

Re: RFR: 8316190: Improve MemorySegment::toString

2023-09-14 Thread Roger Riggs
On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote: > This PR proposes to improve the MemorySegment::toString to reduce cluttering > and add missing comas. Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15740#pullrequestreview-1626999067

Re: RFR: 8316190: Improve MemorySegment::toString

2023-09-14 Thread Roger Riggs
On Thu, 14 Sep 2023 12:02:53 GMT, Per Minborg wrote: >> This PR proposes to improve the MemorySegment::toString to reduce cluttering >> and add missing comas. > > src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277: > >> 275: } >> 276: >> 277: public static String

Re: RFR: 8316190: Improve MemorySegment::toString

2023-09-14 Thread Per Minborg
On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote: > This PR proposes to improve the MemorySegment::toString to reduce cluttering > and add missing comas. src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277: > 275: } > 276: > 277: public static String

RFR: 8316190: Improve MemorySegment::toString

2023-09-14 Thread Per Minborg
This PR proposes to improve the MemorySegment::toString to reduce cluttering and add missing comas. - Commit messages: - Improve MemorySegment::toString Changes: https://git.openjdk.org/jdk/pull/15740/files Webrev: https://webrevs.openjdk.org/?repo=jdk=15740=00 Issue: