On Tue, 3 Oct 2023 06:08:20 GMT, Alan Bateman wrote:
> Surprised this one didn't have DEF_STATIC_JNI_OnLoad already. Change looks
> okay, can you update the copyright date before integrating.
Thanks for the review! Updated copyright year as you suggested.
-
PR Comment: https://git
> Please help review this trivial change that adds missing
> DEF_STATIC_JNI_OnLoad for librmi.
>
> Thanks
Jiangli Zhou has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year as suggested by @AlanBateman.
-
Changes:
On Tue, 3 Oct 2023 02:19:00 GMT, Jiangli Zhou wrote:
> Please help review this trivial change that adds missing
> DEF_STATIC_JNI_OnLoad for librmi.
>
> Thanks
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16020#pullrequestreview-1654871269
On Tue, 3 Oct 2023 02:19:00 GMT, Jiangli Zhou wrote:
> Please help review this trivial change that adds missing
> DEF_STATIC_JNI_OnLoad for librmi.
>
> Thanks
Surprised this one didn't have DEF_STATIC_JNI_OnLoad already. Change looks
okay, can you update the copyright date before integrating.
Please help review this trivial change that adds missing DEF_STATIC_JNI_OnLoad
for librmi.
Thanks
-
Commit messages:
- 8316923: Add DEF_STATIC_JNI_OnLoad for librmi
Changes: https://git.openjdk.org/jdk/pull/16020/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16020&range=
