Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Naoto Sato
On Fri, 27 Oct 2023 22:21:41 GMT, Joe Wang wrote: >> src/java.xml/share/classes/javax/xml/catalog/CatalogResolver.java line 283: >> >>> 281: return type; >>> 282: } >>> 283: } >> >> Instead of looping through all the elements, `Enum.valueOf()`

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Joe Wang
On Fri, 27 Oct 2023 20:41:59 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Impl CSR Changes: change the parameter type from String to Enum > >

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Naoto Sato
On Fri, 27 Oct 2023 19:20:01 GMT, Joe Wang wrote: >> Add a new factory method so that a CatalogResolver can be created with a >> resolve property on top of the Catalog object. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Lance Andersen
On Fri, 27 Oct 2023 19:16:33 GMT, Joe Wang wrote: >> Add a new factory method so that a CatalogResolver can be created with a >> resolve property on top of the Catalog object. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Joe Wang
> Add a new factory method so that a CatalogResolver can be created with a > resolve property on top of the Catalog object. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Impl CSR Changes: change the parameter type from String to Enum