Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v2]

2023-10-25 Thread Jorn Vernee
> Explicitly handle UpcallStub allocation failures by terminating. We currently > might try to use the returned `nullptr` which would fail sooner or later. > This patch just makes the termination explicit. Jorn Vernee has updated the pull request incrementally with one additional commit since t

Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v2]

2023-10-25 Thread Maurizio Cimadamore
On Wed, 25 Oct 2023 10:10:57 GMT, Jorn Vernee wrote: >> Explicitly handle UpcallStub allocation failures by terminating. We >> currently might try to use the returned `nullptr` which would fail sooner or >> later. This patch just makes the termination explicit. > > Jorn Vernee has updated the p

Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v2]

2023-10-26 Thread David Holmes
On Wed, 25 Oct 2023 10:10:57 GMT, Jorn Vernee wrote: >> Explicitly handle UpcallStub allocation failures by terminating. We >> currently might try to use the returned `nullptr` which would fail sooner or >> later. This patch just makes the termination explicit. > > Jorn Vernee has updated the p

Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v2]

2023-10-26 Thread Jorn Vernee
On Thu, 26 Oct 2023 12:17:22 GMT, David Holmes wrote: > Is stub allocation the same as other VM C heap exhaustion cases? I think it depends on the particular case. e.g. `Unsafe::allocateMemory` can also throw OOME. I think an allocation failure in the particular case of the FFM Linker allocat

Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v2]

2023-10-26 Thread Doug Simon
On Wed, 25 Oct 2023 10:10:57 GMT, Jorn Vernee wrote: >> Explicitly handle UpcallStub allocation failures by terminating. We >> currently might try to use the returned `nullptr` which would fail sooner or >> later. This patch just makes the termination explicit. > > Jorn Vernee has updated the p

Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v2]

2023-10-26 Thread Jorn Vernee
On Wed, 25 Oct 2023 10:10:57 GMT, Jorn Vernee wrote: >> Explicitly handle UpcallStub allocation failures by terminating. We >> currently might try to use the returned `nullptr` which would fail sooner or >> later. This patch just makes the termination explicit. > > Jorn Vernee has updated the p