On Fri, 27 Oct 2023 09:09:05 GMT, Jorn Vernee wrote:
> Do you want me to create a separate PR to remove the comment?
No not necessary. Thanks
-
PR Comment: https://git.openjdk.org/jdk/pull/16349#issuecomment-1784664238
On Fri, 27 Oct 2023 05:26:47 GMT, David Holmes wrote:
> @JornVernee please don't forget that all non-trivial (as defined by the dev
> guide) hotspot changes require at least 2 reviews and a 24 hour wait before
> integration. Thanks.
Right, sorry. I think I confused this PR with
https://github
On Thu, 26 Oct 2023 15:02:46 GMT, Jorn Vernee wrote:
>> The result of `FindClass` is a local JNI handle (in
>> `find_class_from_class_loader`, called from `jni_FindClass` [1]). As such,
>> we need to wrap the return value of `FindClass` in a global reference when
>> storing it inside fallbackL
> The result of `FindClass` is a local JNI handle (in
> `find_class_from_class_loader`, called from `jni_FindClass` [1]). As such, we
> need to wrap the return value of `FindClass` in a global reference when
> storing it inside fallbackLinker.c.
>
> While investigating this, I also noticed an e