Re: RFR: 8318776: Require supports_cx8 to always be true [v4]

2023-11-21 Thread David Holmes
On Tue, 21 Nov 2023 16:58:21 GMT, Aleksey Shipilev wrote: >> This looks great! > >> Thanks for the review @fisk ! I have to wait for a few Zero related PRs to >> get integrated then re-merge, before I can integrate. > > Zero patches were pushed, please re-merge. I checked current mainline

Re: RFR: 8318776: Require supports_cx8 to always be true [v4]

2023-11-21 Thread Aleksey Shipilev
On Tue, 21 Nov 2023 06:03:38 GMT, Erik Österlund wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary includes of vm_version.hpp. >> Fix copyright years. > > This looks great! > Thanks for the

Re: RFR: 8318776: Require supports_cx8 to always be true [v4]

2023-11-21 Thread David Holmes
On Tue, 21 Nov 2023 06:03:38 GMT, Erik Österlund wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary includes of vm_version.hpp. >> Fix copyright years. > > This looks great! Thanks for the

Re: RFR: 8318776: Require supports_cx8 to always be true [v4]

2023-11-20 Thread Erik Österlund
On Tue, 21 Nov 2023 05:24:33 GMT, David Holmes wrote: >> As discussed in JBS all platforms (some tweaks to Zero are in progress) >> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip >> out the locked-based alternatives to using it and just add a guarantee that >> it

Re: RFR: 8318776: Require supports_cx8 to always be true [v4]

2023-11-20 Thread David Holmes
> As discussed in JBS all platforms (some tweaks to Zero are in progress) > actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip > out the locked-based alternatives to using it and just add a guarantee that > it is true at runtime. And all platforms except some ARM