Re: RFR: 8318915: Enhance checks in BigDecimal.toPlainString() [v2]

2023-11-08 Thread Brian Burkhalter
On Wed, 8 Nov 2023 09:55:13 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/math/BigDecimal.java line 3510: >> >>> 3508: : intVal.toString(); >>> 3509: int len = str.length() + trailingZeros; >>> 3510: if (len < 0) { >> >> One could u

Re: RFR: 8318915: Enhance checks in BigDecimal.toPlainString() [v2]

2023-11-08 Thread Raffaello Giulietti
On Wed, 8 Nov 2023 00:23:22 GMT, Brian Burkhalter wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Using repeat() instead of loop. > > src/java.base/share/classes/java/math/BigDecimal.java line 3510: > >> 35

Re: RFR: 8318915: Enhance checks in BigDecimal.toPlainString() [v2]

2023-11-07 Thread Brian Burkhalter
On Tue, 7 Nov 2023 19:17:03 GMT, Raffaello Giulietti wrote: >> Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`, >> throwing `OutOfMemoryError` instead to indicate that the resulting `String` >> would be too large. > > Raffaello Giulietti has updated the pull request incr

Re: RFR: 8318915: Enhance checks in BigDecimal.toPlainString() [v2]

2023-11-07 Thread Roger Riggs
On Tue, 7 Nov 2023 19:17:03 GMT, Raffaello Giulietti wrote: >> Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`, >> throwing `OutOfMemoryError` instead to indicate that the resulting `String` >> would be too large. > > Raffaello Giulietti has updated the pull request incr

Re: RFR: 8318915: Enhance checks in BigDecimal.toPlainString() [v2]

2023-11-07 Thread Raffaello Giulietti
On Tue, 7 Nov 2023 18:22:08 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Using repeat() instead of loop. > > src/java.base/share/classes/java/math/BigDecimal.java line 3518: > >> 3516:

Re: RFR: 8318915: Enhance checks in BigDecimal.toPlainString() [v2]

2023-11-07 Thread Raffaello Giulietti
> Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`, > throwing `OutOfMemoryError` instead to indicate that the resulting `String` > would be too large. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Usi

Re: RFR: 8318915: Enhance checks in BigDecimal.toPlainString()

2023-11-07 Thread Roger Riggs
On Wed, 1 Nov 2023 17:40:04 GMT, Raffaello Giulietti wrote: > Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`, > throwing `OutOfMemoryError` instead to indicate that the resulting `String` > would be too large. src/java.base/share/classes/java/math/BigDecimal.java line

RFR: 8318915: Enhance checks in BigDecimal.toPlainString()

2023-11-01 Thread Raffaello Giulietti
Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`, throwing `OutOfMemoryError` instead to indicate that the resulting `String` would be too large. - Commit messages: - 8318915: Enhance checks in BigDecimal.toPlainString() Changes: https://git.openjdk.org/jdk/p