Re: RFR: 8319378: Spec for j.util.Timer::purge and j.util.Timer::cancel could be improved

2023-11-06 Thread Roger Riggs
On Fri, 3 Nov 2023 20:40:11 GMT, Justin Lu wrote: > Please review this PR which clarifies the definition of a _cancelled_ task in > _j.util.Timer::purge_ and _j.util.Timer::cancel_. > > Timer::purge claims that its return value is the number of tasks in the queue > that were cancelled. This ca

Re: RFR: 8319378: Spec for j.util.Timer::purge and j.util.Timer::cancel could be improved

2023-11-05 Thread Jaikiran Pai
On Fri, 3 Nov 2023 20:40:11 GMT, Justin Lu wrote: > Please review this PR which clarifies the definition of a _cancelled_ task in > _j.util.Timer::purge_ and _j.util.Timer::cancel_. > > Timer::purge claims that its return value is the number of tasks in the queue > that were cancelled. This ca

Re: RFR: 8319378: Spec for j.util.Timer::purge and j.util.Timer::cancel could be improved

2023-11-03 Thread Naoto Sato
On Fri, 3 Nov 2023 20:40:11 GMT, Justin Lu wrote: > Please review this PR which clarifies the definition of a _cancelled_ task in > _j.util.Timer::purge_ and _j.util.Timer::cancel_. > > Timer::purge claims that its return value is the number of tasks in the queue > that were cancelled. This ca

RFR: 8319378: Spec for j.util.Timer::purge and j.util.Timer::cancel could be improved

2023-11-03 Thread Justin Lu
Please review this PR which clarifies the definition of a _cancelled_ task in _j.util.Timer::purge_ and _j.util.Timer::cancel_. Timer::purge claims that its return value is the number of tasks in the queue that were cancelled. This can be misleading, as a user can call Timer::cancel, thinking t