On Tue, 4 Jun 2024 01:07:15 GMT, Alexander Matveev wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> EOLs restored
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl
>
On Tue, 4 Jun 2024 02:38:51 GMT, Alexander Matveev wrote:
> I assume WiX5 will just work if installed instead of WiX4?
Correct.
> Do you think it will make sense to introduce Wix5 ToolsetType in case if we
> need to do something different between 4 and 5?
They claim WiX5 is backward compatibl
On Tue, 4 Jun 2024 01:29:15 GMT, Alexey Semenyuk wrote:
> > Is there plan to add support for WiX 5?
>
> This patch supports WiX5 as well. There is not much difference between WiX4
> and WiX5 from jpackage perspective. I'll update the description
I assume WiX5 will just work if installed instea
On Tue, 4 Jun 2024 01:24:15 GMT, Alexander Matveev wrote:
> Is there plan to add support for WiX 5?
This patch supports WiX5 as well. There is not much difference between WiX4 and
WiX5 from jpackage perspective. I'll update the description
-
PR Comment: https://git.openjdk.org/jdk
