RFR: 8319928: Exceptions thrown by cleanup actions passed to reinterpreted segments should be ignored

2023-11-10 Thread Maurizio Cimadamore
This simplePR tweaks the factory which wraps custom cleanup actions passed to `MemorySegment::reinterpret`, so that any exception thrown by the custom cleanup is swallowed when the arena is closed. This aligns the behavior of confined/shared session with that of implicit session (as implicit se

Re: RFR: 8319928: Exceptions thrown by cleanup actions passed to reinterpreted segments should be ignored

2023-11-10 Thread Alan Bateman
On Fri, 10 Nov 2023 16:34:11 GMT, Maurizio Cimadamore wrote: > This simplePR tweaks the factory which wraps custom cleanup actions passed to > `MemorySegment::reinterpret`, so that any exception thrown by the custom > cleanup is swallowed when the arena is closed. > > This aligns the behavior

Re: RFR: 8319928: Exceptions thrown by cleanup actions passed to reinterpreted segments should be ignored

2023-11-10 Thread Maurizio Cimadamore
On Fri, 10 Nov 2023 16:59:09 GMT, Alan Bateman wrote: > @tprinzing This may be an area that you want to look at sometime to see if a > JFR event might make sense. Might make sense - I suggest that should be done also for Cleaner - as that's using same mechanism (and no JFR events) ---

Re: RFR: 8319928: Exceptions thrown by cleanup actions passed to reinterpreted segments should be ignored

2023-11-13 Thread Jorn Vernee
On Fri, 10 Nov 2023 16:34:11 GMT, Maurizio Cimadamore wrote: > This simplePR tweaks the factory which wraps custom cleanup actions passed to > `MemorySegment::reinterpret`, so that any exception thrown by the custom > cleanup is swallowed when the arena is closed. > > This aligns the behavior

Re: RFR: 8319928: Exceptions thrown by cleanup actions passed to reinterpreted segments should be ignored

2023-11-13 Thread Maurizio Cimadamore
On Mon, 13 Nov 2023 08:35:21 GMT, Jorn Vernee wrote: > Not sure whether always swallowing the exceptions is the right move... it > seems like an advantage that explicit arenas _can_ report exceptions thrown > by cleanup actions. Silently ignoring exceptions seems bad, but something > that is f

Re: RFR: 8319928: Exceptions thrown by cleanup actions passed to reinterpreted segments should be ignored

2023-11-13 Thread Maurizio Cimadamore
On Fri, 10 Nov 2023 16:34:11 GMT, Maurizio Cimadamore wrote: > This simplePR tweaks the factory which wraps custom cleanup actions passed to > `MemorySegment::reinterpret`, so that any exception thrown by the custom > cleanup is swallowed when the arena is closed. > > This aligns the behavior

Re: RFR: 8319928: Exceptions thrown by cleanup actions passed to reinterpreted segments should be ignored [v2]

2023-11-13 Thread Maurizio Cimadamore
> This simplePR tweaks the factory which wraps custom cleanup actions passed to > `MemorySegment::reinterpret`, so that any exception thrown by the custom > cleanup is swallowed when the arena is closed. > > This aligns the behavior of confined/shared session with that of implicit > session (as