Re: RFR: 8319928: Exceptions thrown by cleanup actions should be handled correctly [v3]

2023-11-16 Thread Jorn Vernee
On Thu, 16 Nov 2023 18:24:44 GMT, Maurizio Cimadamore wrote: >> This simplePR tweaks the factory which wraps custom cleanup actions passed >> to `MemorySegment::reinterpret`, so that any exception thrown by the custom >> cleanup is swallowed when the arena is closed. >> >> This aligns the beh

Re: RFR: 8319928: Exceptions thrown by cleanup actions should be handled correctly [v3]

2023-11-16 Thread Maurizio Cimadamore
On Thu, 16 Nov 2023 18:27:36 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address CSR comments > > src/java.base/share/classes/jdk/internal/foreign/MemorySessionImpl.java line > 266: >

Re: RFR: 8319928: Exceptions thrown by cleanup actions should be handled correctly [v3]

2023-11-16 Thread Maurizio Cimadamore
On Thu, 16 Nov 2023 18:24:44 GMT, Maurizio Cimadamore wrote: >> This simplePR tweaks the factory which wraps custom cleanup actions passed >> to `MemorySegment::reinterpret`, so that any exception thrown by the custom >> cleanup is swallowed when the arena is closed. >> >> This aligns the beh

Re: RFR: 8319928: Exceptions thrown by cleanup actions should be handled correctly [v3]

2023-11-16 Thread Maurizio Cimadamore
> This simplePR tweaks the factory which wraps custom cleanup actions passed to > `MemorySegment::reinterpret`, so that any exception thrown by the custom > cleanup is swallowed when the arena is closed. > > This aligns the behavior of confined/shared session with that of implicit > session (as