Re: RFR: 8320222: Wrong bytecode accepted, and StackMap table generated [v2]

2023-11-21 Thread Jan Lahoda
On Mon, 20 Nov 2023 17:17:15 GMT, Adam Sotona wrote: >> Stack map generator in ClassFile API performs only minimal checks in favour >> of performance. >> However it led to situations where it generates invalid stack maps for >> corrupted code. >> This patch adds basic checks of stack when two f

Re: RFR: 8320222: Wrong bytecode accepted, and StackMap table generated [v2]

2023-11-20 Thread Adam Sotona
On Thu, 16 Nov 2023 11:25:07 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changed StackMapGenerator::generatorError to return an exception instead >> of directly throw > > src/java.base/share/cla

Re: RFR: 8320222: Wrong bytecode accepted, and StackMap table generated [v2]

2023-11-20 Thread Adam Sotona
> Stack map generator in ClassFile API performs only minimal checks in favour > of performance. > However it led to situations where it generates invalid stack maps for > corrupted code. > This patch adds basic checks of stack when two frames are merged and throws > an exception in case of stack