Re: RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Joe Wang
On Mon, 27 Nov 2023 18:14:53 GMT, Iris Clark wrote: > Verified `synchronized` keyword removed from method declaration as in > upstream source. Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/16829#issuecomment-1828441202

Re: RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Joe Wang
On Mon, 27 Nov 2023 18:17:50 GMT, Lance Andersen wrote: > This looks OK. > > Please add a the appropriate label given there is no test included with this > change so that you do not get asked later where is the test ;-) Added a label and note. Thanks! - PR Comment: https://git.op

Re: RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Lance Andersen
On Mon, 27 Nov 2023 17:24:35 GMT, Joe Wang wrote: > Applying an update from the upstream source, quote: "Removing synchronized > from the getInstance() methods". As the reporter noted, this change was made > 16 years ago. > > Tests: SQE & unit tests passed This looks OK. Please add a the ap

Re: RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Iris Clark
On Mon, 27 Nov 2023 17:24:35 GMT, Joe Wang wrote: > Applying an update from the upstream source, quote: "Removing synchronized > from the getInstance() methods". As the reporter noted, this change was made > 16 years ago. > > Tests: SQE & unit tests passed Verified `synchronized` keyword remo

RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Joe Wang
Applying an update from the upstream source, quote: "Removing synchronized from the getInstance() methods". As the reporter noted, this change was made 16 years ago. Tests: SQE & unit tests passed - Commit messages: - 8320602: Lock contention in SchemaDVFactory.getInstance() Chan