Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Daniel Jeliński
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote: >> The recent cdb versions do not support `.dump /f`: >> >> * >> * .dump /f is not supported on a user mode process. * >> *

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote: >> The recent cdb versions do not support `.dump /f`: >> >> * >> * .dump /f is not supported on a user mode process. * >> *

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 12:04:01 GMT, Daniel Jeliński wrote: > Yes, with `/mA` the command exits as soon as the dump is completed. I > couldn't find a way to make `cdb` not enter interactive mode on unrecognized > parameter, so I left that part as is. Okay, maybe it can be figured out another time

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Magnus Ihse Bursie
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote: >> The recent cdb versions do not support `.dump /f`: >> >> * >> * .dump /f is not supported on a user mode process. * >> *

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Daniel Jeliński
On Fri, 24 Nov 2023 11:36:27 GMT, Alan Bateman wrote: >> It's ignoring the rest of the command line after `/f`, which means it >> ignores the `;qd` (quit and detach) part and enters the interactive mode. > >> It's ignoring the rest of the command line after `/f`, which means it >> ignores the `

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 11:33:57 GMT, Daniel Jeliński wrote: > It's ignoring the rest of the command line after `/f`, which means it ignores > the `;qd` (quit and detach) part and enters the interactive mode. Wonderful :-)Does switching to `/mA` change that? - PR Review Comment: h

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Daniel Jeliński
On Fri, 24 Nov 2023 10:28:30 GMT, Alan Bateman wrote: >> good point, 10 minutes should be more than enough. I'll update. > > Out of curiosity, do we know why it takes more than an hour? Is it attempting > to connect to the Microsoft symbol server? It's ignoring the rest of the command line afte

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Jaikiran Pai
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote: >> The recent cdb versions do not support `.dump /f`: >> >> * >> * .dump /f is not supported on a user mode process. * >> *

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 09:40:16 GMT, Daniel Jeliński wrote: >>> Notice the absence of "params" part in that key. I wonder if that is >>> playing a role here and whether we should fix this key. >> >> Actually ignore that part. I had a look at the internal logs that you >> referenced. It appears th

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Daniel Jeliński
On Fri, 24 Nov 2023 09:09:03 GMT, Alan Bateman wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments > > test/failure_handler/src/share/conf/windows.properties line 60: > >> 58: >> 59: native

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Thomas Stuefe
On Fri, 24 Nov 2023 09:51:07 GMT, Daniel Jeliński wrote: >> test/failure_handler/src/share/conf/windows.properties line 60: >> >>> 58: >>> 59: native.core.app=cdb >>> 60: native.core.args=-c ".dump /ma core.%p;qd" -p %p >> >> Just to double check that this is the right option. `/ma` terminates

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Daniel Jeliński
> The recent cdb versions do not support `.dump /f`: > > * > * .dump /f is not supported on a user mode process. * > * * > *

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete

2023-11-24 Thread Daniel Jeliński
On Fri, 24 Nov 2023 09:17:47 GMT, Jaikiran Pai wrote: >> test/failure_handler/src/share/conf/windows.properties line 61: >> >>> 59: native.core.app=cdb >>> 60: native.core.args=-c ".dump /ma core.%p;qd" -p %p >>> 61: native.core.params.timeout=360 >> >> Hello Daniel, I found it surprising t

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete

2023-11-24 Thread Jaikiran Pai
On Fri, 24 Nov 2023 09:05:15 GMT, Jaikiran Pai wrote: > Notice the absence of "params" part in that key. I wonder if that is playing > a role here and whether we should fix this key. Actually ignore that part. I had a look at the internal logs that you referenced. It appears that this form of

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote: > The recent cdb versions do not support `.dump /f`: > > * > * .dump /f is not supported on a user mode process. * > *

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete

2023-11-24 Thread Jaikiran Pai
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote: > The recent cdb versions do not support `.dump /f`: > > * > * .dump /f is not supported on a user mode process. * > *

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete

2023-11-24 Thread Thomas Stuefe
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote: > The recent cdb versions do not support `.dump /f`: > > * > * .dump /f is not supported on a user mode process. * > *

RFR: 8320691: Timeout handler on Windows takes 2 hours to complete

2023-11-24 Thread Daniel Jeliński
The recent cdb versions do not support `.dump /f`: * * .dump /f is not supported on a user mode process. * * * * .dump /ma c