On Mon, 11 Dec 2023 16:26:52 GMT, Per Minborg wrote:
> This PR is a backport of https://github.com/openjdk/jdk/pull/16993
Looks good (already approved in master)
-
Marked as reviewed by mcimadamore (Reviewer).
PR Review:
This PR is a backport of https://github.com/openjdk/jdk/pull/16993
-
Commit messages:
- Backport d13302f8b06f65319426a25a9368abaf72f3c247
Changes: https://git.openjdk.org/jdk22/pull/7/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22=7=00
Issue:
On Thu, 7 Dec 2023 09:00:46 GMT, Per Minborg wrote:
>> This PR proposes to change the exception type for exceptions thrown for
>> certain methods with a parameter of type `MemorySegment` when it is
>> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
>> was specified
> This PR proposes to change the exception type for exceptions thrown for
> certain methods with a parameter of type `MemorySegment` when it is
> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
> was specified but in some cases, in reality, an
On Wed, 6 Dec 2023 15:36:57 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update throws docs fror SegmentAllocator
>
> src/java.base/share/classes/java/lang/foreign/SegmentAllocator.java
> This PR proposes to change the exception type for exceptions thrown for
> certain methods with a parameter of type `MemorySegment` when it is
> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
> was specified but in some cases, in reality, an
On Wed, 6 Dec 2023 15:32:54 GMT, Per Minborg wrote:
>> This PR proposes to change the exception type for exceptions thrown for
>> certain methods with a parameter of type `MemorySegment` when it is
>> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
>> was specified
On Wed, 6 Dec 2023 15:32:54 GMT, Per Minborg wrote:
>> This PR proposes to change the exception type for exceptions thrown for
>> certain methods with a parameter of type `MemorySegment` when it is
>> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
>> was specified
> This PR proposes to change the exception type for exceptions thrown for
> certain methods with a parameter of type `MemorySegment` when it is
> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
> was specified but in some cases, in reality, an
> This PR proposes to change the exception type for exceptions thrown for
> certain methods with a parameter of type `MemorySegment` when it is
> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
> was specified but in some cases, in reality, an
On Wed, 6 Dec 2023 14:09:31 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.java.template
>> line 153:
>>
>>> 151: static void set(VarHandle ob, Object obb, long base, $type$ value)
>>> {
>>> 152: VarHandleSegmentViewBase
On Wed, 6 Dec 2023 14:06:00 GMT, Maurizio Cimadamore
wrote:
>> This PR proposes to change the exception type for exceptions thrown for
>> certain methods with a parameter of type `MemorySegment` when it is
>> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
>> was
On Wed, 6 Dec 2023 13:52:37 GMT, Per Minborg wrote:
> This PR proposes to change the exception type for exceptions thrown for
> certain methods with a parameter of type `MemorySegment` when it is
> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
> was specified but
On Wed, 6 Dec 2023 13:52:37 GMT, Per Minborg wrote:
> This PR proposes to change the exception type for exceptions thrown for
> certain methods with a parameter of type `MemorySegment` when it is
> `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException`
> was specified but
This PR proposes to change the exception type for exceptions thrown for certain
methods with a parameter of type `MemorySegment` when it is
`MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException` was
specified but in some cases, in reality, an `IllegalArgumentException` was
15 matches
Mail list logo