On Tue, 9 Jan 2024 19:27:12 GMT, Justin Lu wrote:
> Please review this PR which is the backport of the ISO 4217 Amendment 176
> Update. Commit
> [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc)
> from the [openjdk/jdk](https://git.openjdk.org/jdk)
On Tue, 9 Jan 2024 19:27:12 GMT, Justin Lu wrote:
> Please review this PR which is the backport of the ISO 4217 Amendment 176
> Update. Commit
> [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc)
> from the [openjdk/jdk](https://git.openjdk.org/jdk)
Please review this PR which is the backport of the ISO 4217 Amendment 176
Update. Commit
[8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
-
Commit messages:
- Backport
On Mon, 11 Dec 2023 22:15:42 GMT, Justin Lu wrote:
>> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
>> As the replacement of `ANG` to `XCG` won't occur until 2025, this change
>> does not need to go into JDK22. `HR` was also updated to remove the past
>> cutover
On Mon, 11 Dec 2023 23:59:24 GMT, Naoto Sato wrote:
>> Well, at first I had intended for the `notSimpleCurrency` to encapsulate all
>> 3 cases. But upon further investigation, I think the current code is
>> redundant.
>>
>> The third conditional, `(tableEntry &
On Mon, 11 Dec 2023 22:04:23 GMT, Justin Lu wrote:
>> make/jdk/src/classes/build/tools/generatecurrencydata/GenerateCurrencyData.java
>> line 347:
>>
>>> 345: // otherwise it will leak out into
>>> Currency:getAvailableCurrencies
>>> 346: boolean notFutureCurrency =
On Mon, 11 Dec 2023 22:06:58 GMT, Justin Lu wrote:
>> IIUC, this should have happened before, as a currency update like "XXA" ->
>> "XXB" on a future date is pretty usual. I think this issue was simply not
>> discovered by any users till now.
>
> I think this wasn't discovered/hasn't failed
On Mon, 11 Dec 2023 19:42:30 GMT, Naoto Sato wrote:
>> Updated the Currency build process to disallow any Currencies that are
>> future Currencies. This prevents the future currency, "XCG" from leaking out
>> into `Currency.getAvailableCurrencies()`. (This was only exposed now, since
>> the
On Mon, 11 Dec 2023 19:38:38 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>>
> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
> As the replacement of `ANG` to `XCG` won't occur until 2025, this change does
> not need to go into JDK22. `HR` was also updated to remove the past cutover
> dates.
>
> An existing test in _ValidateISO4217.java_
On Mon, 11 Dec 2023 03:03:44 GMT, Justin Lu wrote:
>> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
>> As the replacement of `ANG` to `XCG` won't occur until 2025, this change
>> does not need to go into JDK22. `HR` was also updated to remove the past
>> cutover
On Mon, 11 Dec 2023 02:59:02 GMT, Justin Lu wrote:
>> test/jdk/java/util/Currency/ValidateISO4217.java line 181:
>>
>>> 179: // without updating ISO4217Codes
>>> 180: String futureCurr = tokens.nextToken();
>>> 181:
>>>
On Thu, 7 Dec 2023 22:20:29 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>>
> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
> As the replacement of `ANG` to `XCG` won't occur until 2025, this change does
> not need to go into JDK22. `HR` was also updated to remove the past cutover
> dates.
>
> An existing test in _ValidateISO4217.java_
On Thu, 7 Dec 2023 19:43:14 GMT, Justin Lu wrote:
> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
> As the replacement of `ANG` to `XCG` won't occur until 2025, this change does
> not need to go into JDK22. `HR` was also updated to remove the past cutover
>
Please review this PR which incorporates the ISO 4217 Amendment 176 Update. As
the replacement of `ANG` to `XCG` won't occur until 2025, this change does not
need to go into JDK22. `HR` was also updated to remove the past cutover dates.
An existing test in _ValidateISO4217.java_ checked that
16 matches
Mail list logo
