Re: RFR: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile [v9]

2024-01-08 Thread Eirik Bjørsnøs
On Mon, 8 Jan 2024 17:30:51 GMT, Lance Andersen wrote: > Changes look fine. Probably need to change the copyright from 2023 -> 2024 No IP was produced in 2024 for most of these files, but I've updated them anyhow. - PR Comment:

Re: RFR: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile [v9]

2024-01-08 Thread Lance Andersen
On Tue, 2 Jan 2024 13:31:01 GMT, Eirik Bjørsnøs wrote: >> This PR suggests we retire the binary test vectors `ZipFile/input.zip`, >> `ZipFile/input.jar` and `ZipFile/crash.jar` >> >> Binary test vectors are harder to analyze, and sharing test vectors across >> unrelated tests increases

Re: RFR: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile [v9]

2024-01-02 Thread Eirik Bjørsnøs
> This PR suggests we retire the binary test vectors `ZipFile/input.zip`, > `ZipFile/input.jar` and `ZipFile/crash.jar` > > Binary test vectors are harder to analyze, and sharing test vectors across > unrelated tests increases maintenance burden. It would be better to have each > test produce