Re: RFR: 8323601: Improve LayoutPath.PathElement::toString [v4]

2024-01-31 Thread Maurizio Cimadamore
On Tue, 30 Jan 2024 16:58:35 GMT, Per Minborg wrote: >> This PR proposes to add an improved Improve >> `LayoutPath.PathElement::toString` method simplifying debugging. >> >> Opinions and suggestions for `static PathElement sequenceElement(long start, >> long step)` are welcome. > > Per

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString [v4]

2024-01-30 Thread Jorn Vernee
On Tue, 30 Jan 2024 16:58:35 GMT, Per Minborg wrote: >> This PR proposes to add an improved Improve >> `LayoutPath.PathElement::toString` method simplifying debugging. >> >> Opinions and suggestions for `static PathElement sequenceElement(long start, >> long step)` are welcome. > > Per

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString [v4]

2024-01-30 Thread Per Minborg
> This PR proposes to add an improved Improve > `LayoutPath.PathElement::toString` method simplifying debugging. > > Opinions and suggestions for `static PathElement sequenceElement(long start, > long step)` are welcome. Per Minborg has updated the pull request incrementally with one

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString [v2]

2024-01-29 Thread Maurizio Cimadamore
On Mon, 29 Jan 2024 17:22:07 GMT, Per Minborg wrote: >> Correct. Additional logic is needed to form a correct C syntax. It would be >> possible to provide a method that does this. > > We could add such a method under another issue > (https://bugs.openjdk.org/browse/JDK-8323746) because it will

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString [v3]

2024-01-29 Thread Per Minborg
> This PR proposes to add an improved Improve > `LayoutPath.PathElement::toString` method simplifying debugging. > > Opinions and suggestions for `static PathElement sequenceElement(long start, > long step)` are welcome. Per Minborg has updated the pull request with a new target base due to a

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString [v2]

2024-01-29 Thread Per Minborg
On Tue, 16 Jan 2024 09:10:04 GMT, Per Minborg wrote: >> src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 958: >> >>> 956: return new >>> LayoutPath.PathElementImpl(PathKind.DEREF_ELEMENT, >>> 957: LayoutPath::derefElement, >>> 958:

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString [v2]

2024-01-16 Thread Per Minborg
On Mon, 15 Jan 2024 17:10:47 GMT, Jorn Vernee wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rework PathElement:toString > > src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 958: > >> 956:

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString [v2]

2024-01-15 Thread Jorn Vernee
On Mon, 15 Jan 2024 16:01:32 GMT, Per Minborg wrote: >> This PR proposes to add an improved Improve >> `LayoutPath.PathElement::toString` method simplifying debugging. >> >> Opinions and suggestions for `static PathElement sequenceElement(long start, >> long step)` are welcome. > > Per

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString [v2]

2024-01-15 Thread Per Minborg
> This PR proposes to add an improved Improve > `LayoutPath.PathElement::toString` method simplifying debugging. > > Opinions and suggestions for `static PathElement sequenceElement(long start, > long step)` are welcome. Per Minborg has updated the pull request incrementally with one

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString

2024-01-15 Thread Maurizio Cimadamore
On Mon, 15 Jan 2024 07:57:00 GMT, Per Minborg wrote: >> This PR proposes to add an improved Improve >> `LayoutPath.PathElement::toString` method simplifying debugging. >> >> Opinions and suggestions for `static PathElement sequenceElement(long start, >> long step)` are welcome. > >

Re: RFR: 8323601: Improve LayoutPath.PathElement::toString

2024-01-15 Thread Per Minborg
On Mon, 15 Jan 2024 07:56:13 GMT, Per Minborg wrote: > This PR proposes to add an improved Improve > `LayoutPath.PathElement::toString` method simplifying debugging. > > Opinions and suggestions for `static PathElement sequenceElement(long start, > long step)` are welcome.

RFR: 8323601: Improve LayoutPath.PathElement::toString

2024-01-15 Thread Per Minborg
This PR proposes to add an improved Improve `LayoutPath.PathElement::toString` method simplifying debugging. Opinions and suggestions for `static PathElement sequenceElement(long start, long step)` are welcome. - Commit messages: - Add toString to PathElement Changes: