On Sat, 3 Feb 2024 11:28:51 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make all PathElements records
>
> src/java.base/share/classes/jdk/internal/foreign/LayoutPath.java line 494:
>
>> 492:
> This PR proposes to implement `hashCode()` and `equals()` methods for
> implementations of `PathElement`.
>
> In doing so, the previous `PathElementImpl` was removed and replaced in favor
> of distinct `record` implementations, each reflecting its own path element
> selection type. This also
On Fri, 2 Feb 2024 07:41:16 GMT, Per Minborg wrote:
>> This PR proposes to implement `hashCode()` and `equals()` methods for
>> implementations of `PathElement`.
>>
>> In doing so, the previous `PathElementImpl` was removed and replaced in
>> favor of distinct `record` implementations, each re
On Fri, 2 Feb 2024 07:41:16 GMT, Per Minborg wrote:
>> This PR proposes to implement `hashCode()` and `equals()` methods for
>> implementations of `PathElement`.
>>
>> In doing so, the previous `PathElementImpl` was removed and replaced in
>> favor of distinct `record` implementations, each re
> This PR proposes to implement `hashCode()` and `equals()` methods for
> implementations of `PathElement`.
>
> In doing so, the previous `PathElementImpl` was removed and replaced in favor
> of distinct `record` implementations, each reflecting its own path element
> selection type. This also
On Thu, 1 Feb 2024 14:25:24 GMT, Per Minborg wrote:
>> src/java.base/share/classes/jdk/internal/foreign/LayoutPath.java line 454:
>>
>>> 452: }
>>> 453:
>>> 454: public static final class SequenceElement
>>
>> Why are these not empty records?
>
> I had that in the beginning but convert
On Wed, 31 Jan 2024 18:21:09 GMT, Maurizio Cimadamore
wrote:
>> This PR proposes to implement `hashCode()` and `equals()` methods for
>> implementations of `PathElement`.
>>
>> In doing so, the previous `PathElementImpl` was removed and replaced in
>> favor of distinct `record` implementation
On Wed, 31 Jan 2024 13:04:07 GMT, Per Minborg wrote:
> This PR proposes to implement `hashCode()` and `equals()` methods for
> implementations of `PathElement`.
>
> In doing so, the previous `PathElementImpl` was removed and replaced in favor
> of distinct `record` implementations, each reflec
This PR proposes to implement `hashCode()` and `equals()` methods for
implementations of `PathElement`.
In doing so, the previous `PathElementImpl` was removed and replaced in favor
of distinct `record` implementations, each reflecting its own path element
selection type. This also allowed the
