Re: RFR: 8325950: Make sure all files in the JDK pass jcheck [v2]

2024-02-16 Thread Naoto Sato
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote: >> Since jcheck only checks file in a commit, there is a possibility of us >> getting files in the repository that would not be accepted by jcheck. This >> can happen when extending the set of files checked by jcheck, or if jcheck >>

Re: RFR: 8325950: Make sure all files in the JDK pass jcheck [v2]

2024-02-16 Thread Erik Joelsson
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote: >> Since jcheck only checks file in a commit, there is a possibility of us >> getting files in the repository that would not be accepted by jcheck. This >> can happen when extending the set of files checked by jcheck, or if jcheck >>

Re: RFR: 8325950: Make sure all files in the JDK pass jcheck [v2]

2024-02-16 Thread Magnus Ihse Bursie
On Thu, 15 Feb 2024 17:53:41 GMT, Naoto Sato wrote: >> `\u000b` is VT (vertical tab) >> `\u0009` or `\t` perhaps? > > Right. `\t` is better to avoid such a mistake. Ok, fixed. - PR Review Comment: https://git.openjdk.org/jdk/pull/17871#discussion_r1492403403

Re: RFR: 8325950: Make sure all files in the JDK pass jcheck [v2]

2024-02-16 Thread Magnus Ihse Bursie
> Since jcheck only checks file in a commit, there is a possibility of us > getting files in the repository that would not be accepted by jcheck. This > can happen when extending the set of files checked by jcheck, or if jcheck > changes how it checks files (perhaps due to bug fixes). > > I