On Wed, 12 Jun 2024 09:35:12 GMT, Jaikiran Pai wrote:
>> Chris Hennick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Bug fix: add-exports was for wrong package
>
> test/jdk/jdk/internal/util/random/RandomSupportTest.java line 32:
>
>>
On Wed, 12 Jun 2024 08:16:25 GMT, Jaikiran Pai wrote:
>> Chris Hennick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Bug fix: add-exports was for wrong package
>
> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java
On Wed, 12 Jun 2024 09:23:23 GMT, Jaikiran Pai wrote:
>> Chris Hennick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Bug fix: add-exports was for wrong package
>
> test/jdk/jdk/internal/util/random/RandomSupportTest.java line 5:
>
>>
On Wed, 12 Jun 2024 10:08:02 GMT, Jaikiran Pai wrote:
>>> Update: confirmed that the new test fails without the fix.
>>
>> Thanks for verifying the test checks the fix; I'll let others who have
>> worked more directly on the random code review the actual fix.
>
>> @jddarcy Added a regression te
On Thu, 22 Feb 2024 05:40:10 GMT, Joe Darcy wrote:
>> Update: confirmed that the new test fails without the fix.
>
>> Update: confirmed that the new test fails without the fix.
>
> Thanks for verifying the test checks the fix; I'll let others who have worked
> more directly on the random code r
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Thu, 9 May 2024 03:55:15 GMT, Chris Hennick wrote:
>> Chris Hennick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Bug fix: add-exports was for wrong package
>
> Keep open.
>
> @JimLaskey it looks like you're the author of most of
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Thu, 29 Feb 2024 01:54:54 GMT, Chris Hennick wrote:
>> Chris Hennick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Bug fix: add-exports was for wrong package
>
> @turbanoff @rgiulietti This is a follow-up to my previously merged #81
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when the computed bound is greater than
>> `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could cause the
>> `while (computeNex
On Thu, 22 Feb 2024 03:01:58 GMT, Chris Hennick wrote:
> Update: confirmed that the new test fails without the fix.
Thanks for verifying the test checks the fix; I'll let others who have worked
more directly on the random code review the actual fix.
-
PR Comment: https://git.openj
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when the computed bound is greater than
>> `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could cause the
>> `while (computeNex
> This provides a slightly more accurate bounding limit for
> `computeNextExponentialSoftCapped` when the computed bound is greater than
> `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could cause the
> `while (computeNextExponentialSoftCapped(rng, limit) < limit)` check in
> `com
19 matches
Mail list logo
