Re: RFR: 8327791: Optimization for new BigDecimal(String) [v8]

2024-03-12 Thread Shaojin Wen
> The current BigDecimal(String) constructor calls String#toCharArray, which > has a memory allocation. > > > public BigDecimal(String val) { > this(val.toCharArray(), 0, val.length()); // allocate char[] > } > > > When the length is greater than 18, create a char[] > > > boolean isCompa

Re: RFR: 8327791: Optimization for new BigDecimal(String) [v8]

2024-03-12 Thread Claes Redestad
On Tue, 12 Mar 2024 10:34:33 GMT, Shaojin Wen wrote: >> The current BigDecimal(String) constructor calls String#toCharArray, which >> has a memory allocation. >> >> >> public BigDecimal(String val) { >> this(val.toCharArray(), 0, val.length()); // allocate char[] >> } >> >> >> When the l

Re: RFR: 8327791: Optimization for new BigDecimal(String) [v8]

2024-03-12 Thread Claes Redestad
On Tue, 12 Mar 2024 10:34:33 GMT, Shaojin Wen wrote: >> The current BigDecimal(String) constructor calls String#toCharArray, which >> has a memory allocation. >> >> >> public BigDecimal(String val) { >> this(val.toCharArray(), 0, val.length()); // allocate char[] >> } >> >> >> When the l

Re: RFR: 8327791: Optimization for new BigDecimal(String) [v8]

2024-03-12 Thread Claes Redestad
On Tue, 12 Mar 2024 10:34:33 GMT, Shaojin Wen wrote: >> The current BigDecimal(String) constructor calls String#toCharArray, which >> has a memory allocation. >> >> >> public BigDecimal(String val) { >> this(val.toCharArray(), 0, val.length()); // allocate char[] >> } >> >> >> When the l