Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v13]

2024-04-12 Thread Scott Gibbons
On Fri, 12 Apr 2024 00:14:29 GMT, Sandhya Viswanathan wrote: >> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing yet more review comments > > src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2504: > >

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v13]

2024-04-12 Thread Scott Gibbons
On Fri, 12 Apr 2024 00:25:34 GMT, Sandhya Viswanathan wrote: >> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2521: >> >>> 2519: const Register byteVal = rdx; >>> 2520: >>> 2521: // Propagate byte to full Register >> >> The comment refers to lines 2524-2526, please m

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v13]

2024-04-11 Thread Sandhya Viswanathan
On Fri, 12 Apr 2024 00:10:22 GMT, Sandhya Viswanathan wrote: >> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing yet more review comments > > src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2521: > >

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v13]

2024-04-11 Thread Sandhya Viswanathan
On Fri, 12 Apr 2024 00:07:56 GMT, Scott Gibbons wrote: >> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See >> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around >> this change. >> >> Overall, making this an intrinsic improves overall performanc

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v13]

2024-04-11 Thread Scott Gibbons
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See > [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around > this change. > > Overall, making this an intrinsic improves overall performance of > `Unsafe::setMemory` by up to 4x for all buffer sizes.