On Mon, 15 Apr 2024 23:06:11 GMT, Sandhya Viswanathan
wrote:
>> `_WIN32` is also defined for 64 bit Windows
>
> Thanks, I missed that.
I'm changing the scheme here to c_rargX, so no need for any windows-specific
stuff. I added it when I needed 4 scratch registers.
-
PR Review Co
On Mon, 15 Apr 2024 23:01:21 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2686:
>>
>>> 2684: __ movq(rdx, rsi);
>>> 2685: restore_arg_regs();
>>> 2686: #endif
>>
>> This is stubGenerator_x86_64.cpp 64bit specific, so WIN32 portion could be
On Mon, 15 Apr 2024 22:22:38 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix memory mark after sync to upstream
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2686:
>
On Mon, 15 Apr 2024 18:43:24 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall performanc
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
