On Thu, 9 May 2024 19:48:53 GMT, Sonia Zaldana Calles
wrote:
>> Pre-existing: Man, I cannot grok the complex return code handling, tbh.
>>
>> We have the local `ret` variable holding a return code. We also hand codes
>> to CHECK_EXCEPTION_LEAVE as macro argument. But we don't hand codes to
>>
On Thu, 9 May 2024 19:48:53 GMT, Sonia Zaldana Calles
wrote:
> > This may be food for another RFE, to keep this patch minimal. But a good
> > solution, to me, would be like this:
> >
> > * have the same logic for return codes (1 = error, 0 = success) to ease
> > understanding
> > * have clear
On Wed, 8 May 2024 09:37:58 GMT, Thomas Stuefe wrote:
> This may be food for another RFE, to keep this patch minimal. But a good
> solution, to me, would be like this:
>
> * have the same logic for return codes (1 = error, 0 = success) to ease
> understanding
> * have clearly named constants (
On Mon, 6 May 2024 19:06:10 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the is
On Mon, 6 May 2024 19:06:10 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the is
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue linked above,
> [LauncherHelper#getMainType](https://github.com/open
