On Fri, 19 Apr 2024 09:20:27 GMT, Christoph Langer wrote:
> This trace seems a bit unsymmetric to its Windows counterpart. Maybe it
> should be left out here, too, since there is tracing in GetJREPath.
I removed the JLI trace output for the launcher exe path.
-
PR Review Comment:
On Thu, 18 Apr 2024 06:57:05 GMT, Matthias Baesken wrote:
>> We have already good JLI tracing capabilities. But GetApplicationHome and
>> GetApplicationHomeFromDll lack some tracing and should be enhanced.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional
On Thu, 18 Apr 2024 06:31:03 GMT, Alan Bateman wrote:
>> Hi Christoph, seems the USE_REGISTRY_LOOKUP is currently unused (at least
>> without additional defines that are not present usually)
>>
>> src/java.base/windows/native/libjli/java_md.c:52:#ifdef USE_REGISTRY_LOOKUP
>>
> We have already good JLI tracing capabilities. But GetApplicationHome and
> GetApplicationHomeFromDll lack some tracing and should be enhanced.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
remove obsolete
