Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute [v2]

2024-04-26 Thread Raffaello Giulietti
On Fri, 26 Apr 2024 01:35:56 GMT, Joe Darcy wrote: >> Remove unnecessary setting of variable y, found by an IDE inspection noted >> in the bug report. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright year.

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute [v2]

2024-04-25 Thread Joe Darcy
> Remove unnecessary setting of variable y, found by an IDE inspection noted in > the bug report. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update copyright year. - Changes: - all:

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Brian Burkhalter
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote: > Remove unnecessary setting of variable y, found by an IDE inspection noted in > the bug report. Marked as reviewed by bpb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18963#pullrequestreview-2023708504

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Naoto Sato
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote: > Remove unnecessary setting of variable y, found by an IDE inspection noted in > the bug report. Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18963#pullrequestreview-2023687212

RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Joe Darcy
Remove unnecessary setting of variable y, found by an IDE inspection noted in the bug report. - Commit messages: - JDK-8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute Changes: https://git.openjdk.org/jdk/pull/18963/files Webrev:

Re: RFR: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute

2024-04-25 Thread Joe Darcy
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote: > Remove unnecessary setting of variable y, found by an IDE inspection noted in > the bug report. All Math and StrictMath regression tests pass with this change. Examining the code, y does look to be overwritten on all the code paths where it