Re: RFR: 8331187: Optimize MethodTypeDesc and ClassDesc.ofDescriptor for primitive types [v2]

2024-04-26 Thread Jorn Vernee
On Fri, 26 Apr 2024 11:49:19 GMT, Claes Redestad wrote: > > Does removing the explicit null checks make that much difference for > > performance? They are kind of nice for clarity. > > It helps startup at least. The redundant array depth check mattered a bit for > peak performance, but not

Re: RFR: 8331187: Optimize MethodTypeDesc and ClassDesc.ofDescriptor for primitive types [v2]

2024-04-26 Thread Claes Redestad
On Fri, 26 Apr 2024 11:27:35 GMT, Jorn Vernee wrote: > Looks like your `MethodTypeDescFactories` benchmark is missing form the PR? > Pre-existing. > Does removing the explicit null checks make that much difference for > performance? They are kind of nice for clarity. > It helps startup at

Re: RFR: 8331187: Optimize MethodTypeDesc and ClassDesc.ofDescriptor for primitive types [v2]

2024-04-26 Thread Jorn Vernee
On Fri, 26 Apr 2024 10:54:49 GMT, Claes Redestad wrote: >> This PR makes ClassDesc.ofDescriptor return the shared constant for >> primitive descriptor strings ("I" etc..), and leverages this further by >> refactoring `MethodTypeDescImpl.ofDescriptor` to avoid the intermediate >> substring for

Re: RFR: 8331187: Optimize MethodTypeDesc and ClassDesc.ofDescriptor for primitive types [v2]

2024-04-26 Thread Claes Redestad
> This PR makes ClassDesc.ofDescriptor return the shared constant for primitive > descriptor strings ("I" etc..), and leverages this further by refactoring > `MethodTypeDescImpl.ofDescriptor` to avoid the intermediate substring for > primitives. > > Microbenchmarks results look good with