On Wed, 22 May 2024 21:06:11 GMT, Pavel Rappo wrote:
> Okay, but can we call it a best-effort attempt to restore the echo state? I
> guess, it is a judgement call.
That would be fair, and exactly what I am aiming for, considering we can do
nothing for the `halt()` case.
-
PR Comm
On Wed, 22 May 2024 19:32:07 GMT, Naoto Sato wrote:
> > I might be confused, but what if the shutdown hook completes and then some
> > application thread enters `readPassword`. If that thread manages to turn
> > off echo before all other shutdown hooks complete, it might never execute
> > `fin
On Wed, 22 May 2024 18:35:40 GMT, Pavel Rappo wrote:
> I might be confused, but what if the shutdown hook completes and then some
> application thread enters `readPassword`. If that thread manages to turn off
> echo before all other shutdown hooks complete, it might never execute
> `finally`,
On Wed, 22 May 2024 17:20:02 GMT, Naoto Sato wrote:
> Hi Pavel,
>
> > If I read
> > [this](https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/lang/Runtime.html#shutdown)
> > correctly, due to the mechanics of JVM exit, we simply don't know which
> > thread finishes first: a thr
On Tue, 21 May 2024 22:51:14 GMT, Naoto Sato wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown
>> thread, which differs from the application's thread that issues the
>> `readPassword()` method.
>
> Naoto Sato has updated the pull request incrementally with one add
On Tue, 21 May 2024 22:51:14 GMT, Naoto Sato wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown
>> thread, which differs from the application's thread that issues the
>> `readPassword()` method.
>
> Naoto Sato has updated the pull request incrementally with one add
On Tue, 21 May 2024 22:51:14 GMT, Naoto Sato wrote:
>> Making sure `restoreEcho` correctly reflects the state in the shutdown
>> thread, which differs from the application's thread that issues the
>> `readPassword()` method.
>
> Naoto Sato has updated the pull request incrementally with one add
> Making sure `restoreEcho` correctly reflects the state in the shutdown
> thread, which differs from the application's thread that issues the
> `readPassword()` method.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Used a dedicate
