Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option [v2]

2024-05-31 Thread Michael Hall
Yes you can file an Apple bug report but I think these days it requires a developer account to get to the bug reporter. The indicated documentation doesn’t mention anything about your own files/directories. So I think a bug report might be appropriate. One in but the other out doesn’t seem righ

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option [v2]

2024-05-31 Thread Alexander Matveev
On Fri, 31 May 2024 21:36:56 GMT, Nir Lisker wrote: > I see, but it doesn't say where to put license files, which are usually in > the root. Do you know where these belong? No idea. - PR Comment: https://git.openjdk.org/jdk/pull/19377#issuecomment-2143025767

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option [v2]

2024-05-31 Thread Nir Lisker
On Thu, 30 May 2024 22:54:12 GMT, Alexander Matveev wrote: >> This issue is reproducible with and without `--mac-sign`. jpackage will >> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by >> using pseudo-identity "_-_". This is why jpackage tries to sign added files >> a

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option

2024-05-31 Thread Alexander Matveev
On Fri, 31 May 2024 20:43:45 GMT, Nir Lisker wrote: > > > For your example. This almost seems like an Apple bug if you can add a > > > directory to the Contents directory but not a file? > > > > > > Not sure if it is an Apple bug. > > Can this be reported to Apple somehow? I do not think tha

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option

2024-05-31 Thread Nir Lisker
On Sat, 25 May 2024 01:12:56 GMT, Alexander Matveev wrote: > > For your example. This almost seems like an Apple bug if you can add a > > directory to the Contents directory but not a file? > > Not sure if it is an Apple bug. Can this be reported to Apple somehow? - PR Comment:

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option [v2]

2024-05-31 Thread Alexander Matveev
On Thu, 30 May 2024 14:21:51 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8332110: jpackage tries to sign added files without the --mac-sign option >> [v2] > > test/jdk/tools/jpackage/

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option [v2]

2024-05-30 Thread Alexey Semenyuk
On Thu, 30 May 2024 22:54:12 GMT, Alexander Matveev wrote: >> This issue is reproducible with and without `--mac-sign`. jpackage will >> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by >> using pseudo-identity "_-_". This is why jpackage tries to sign added files >> a

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option [v2]

2024-05-30 Thread Alexander Matveev
On Thu, 30 May 2024 22:54:12 GMT, Alexander Matveev wrote: >> This issue is reproducible with and without `--mac-sign`. jpackage will >> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by >> using pseudo-identity "_-_". This is why jpackage tries to sign added files >> a

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option [v2]

2024-05-30 Thread Alexander Matveev
> This issue is reproducible with and without `--mac-sign`. jpackage will > "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by > using pseudo-identity "_-_". This is why jpackage tries to sign added files > and this is expected behavior by jpackage. "codesign" fails since a

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option

2024-05-30 Thread Alexey Semenyuk
On Fri, 24 May 2024 01:08:03 GMT, Alexander Matveev wrote: > This issue is reproducible with and without `--mac-sign`. jpackage will > "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by > using pseudo-identity "_-_". This is why jpackage tries to sign added files > and t

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option

2024-05-28 Thread Alexander Matveev
On Fri, 24 May 2024 01:08:03 GMT, Alexander Matveev wrote: > This issue is reproducible with and without `--mac-sign`. jpackage will > "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by > using pseudo-identity "_-_". This is why jpackage tries to sign added files > and t

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option

2024-05-24 Thread Alexander Matveev
: [macos] jpackage tries to sign added files without the --mac-sign option On May 24, 2024, at 3:08 AM, Michael Hall wrote: On May 23, 2024, at 8:13 PM, Alexander Matveev mailto:almat...@openjdk.org>> wrote: otherwise add additional content as post-processing step. Doesn’t this

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option

2024-05-24 Thread Michael Hall
> On May 24, 2024, at 3:08 AM, Michael Hall wrote: > >> On May 23, 2024, at 8:13 PM, Alexander Matveev > > wrote: >> >> otherwise add additional content as post-processing step. > > Doesn’t this still leave you with an application that isn’t validly signed? > And

RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option

2024-05-23 Thread Alexander Matveev
This issue is reproducible with and without `--mac-sign`. jpackage will "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by using pseudo-identity "_-_". This is why jpackage tries to sign added files and this is expected behavior by jpackage. "codesign" fails since added con