Re: RFR: 8333396: Performance regression of DecimalFormat.format [v13]

2024-06-27 Thread Naoto Sato
On Thu, 27 Jun 2024 18:31:30 GMT, Justin Lu wrote: >> lingjun-cg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 896: Performance regression of DecimalFormat.format > > test/micro/org/openjdk/bench/java/text/DefFormatterBench.java li

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v13]

2024-06-27 Thread Chen Liang
On Thu, 27 Jun 2024 11:09:27 GMT, lingjun-cg wrote: >> ### Performance regression of DecimalFormat.format >> From the output of perf, we can see the hottest regions contain atomic >> instructions. But when run with JDK 11, there is no such problem. The >> reason is the removed biased locking.

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v13]

2024-06-27 Thread Justin Lu
On Thu, 27 Jun 2024 11:09:27 GMT, lingjun-cg wrote: >> ### Performance regression of DecimalFormat.format >> From the output of perf, we can see the hottest regions contain atomic >> instructions. But when run with JDK 11, there is no such problem. The >> reason is the removed biased locking.

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v13]

2024-06-27 Thread lingjun-cg
> ### Performance regression of DecimalFormat.format > From the output of perf, we can see the hottest regions contain atomic > instructions. But when run with JDK 11, there is no such problem. The reason > is the removed biased locking. > The DecimalFormat uses StringBuffer everywhere, and St