Re: RFR: 8333396: Performance regression of DecimalFormat.format [v17]

2024-07-08 Thread Justin Lu
On Mon, 8 Jul 2024 02:32:17 GMT, lingjun-cg wrote: >> ### Performance regression of DecimalFormat.format >> From the output of perf, we can see the hottest regions contain atomic >> instructions. But when run with JDK 11, there is no such problem. The >> reason is the removed biased locking.

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v17]

2024-07-08 Thread Naoto Sato
On Mon, 8 Jul 2024 03:06:17 GMT, Chen Liang wrote: > Quick question about the violation of the "This is equivalent to" spec: Does > our new implementation lead to any observable side effects that make the > returned results or thrown exceptions different from that of `format(obj, new > StringB

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v17]

2024-07-07 Thread Chen Liang
On Mon, 8 Jul 2024 02:32:17 GMT, lingjun-cg wrote: >> ### Performance regression of DecimalFormat.format >> From the output of perf, we can see the hottest regions contain atomic >> instructions. But when run with JDK 11, there is no such problem. The >> reason is the removed biased locking.

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v17]

2024-07-07 Thread lingjun-cg
> ### Performance regression of DecimalFormat.format > From the output of perf, we can see the hottest regions contain atomic > instructions. But when run with JDK 11, there is no such problem. The reason > is the removed biased locking. > The DecimalFormat uses StringBuffer everywhere, and St