Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-14 Thread Valerie Peng
On Fri, 14 Jun 2024 09:47:31 GMT, Ferenc Rakoczi wrote: >> src/java.base/share/classes/sun/security/provider/SHA3.java line 73: >> >>> 71: // The following array is allocated to size WIDTH bytes, but we only >>> 72: // ever use the first blockSize bytes it (for bytes <-> long >>>

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-14 Thread Ferenc Rakoczi
On Thu, 13 Jun 2024 20:25:22 GMT, Valerie Peng wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix clone(), accept review suggestions. > > src/java.base/share/classes/sun/security/provider/SHA3.java line 73: >

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-14 Thread Ferenc Rakoczi
On Fri, 14 Jun 2024 05:56:05 GMT, Andrey Turbanov wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix clone(), accept review suggestions. > > src/java.base/share/classes/sun/security/provider/SHA3.java line 152:

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-13 Thread Andrey Turbanov
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-13 Thread Valerie Peng
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Vladimir Kozlov
On Wed, 12 Jun 2024 20:04:40 GMT, Ferenc Rakoczi wrote: > tier1,2,3 mach5 tests all passed. Thank you for testing. - PR Comment: https://git.openjdk.org/jdk/pull/19632#issuecomment-2163863932

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Vladimir Kozlov
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Ferenc Rakoczi
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Ferenc Rakoczi
On Tue, 11 Jun 2024 18:21:49 GMT, Daniel Jeliński wrote: >> okay > > Could you try using MethodHandles instead of b2lLittle? Similar to what's > used in ChaCha20: >

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Ferenc Rakoczi
> This PR removes some unnecessary conversions between byte arrays and long > arrays during SHA3 digest computations. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Fix clone(), accept review suggestions. - Changes: