Re: RFR: 8333962: Obsolete OldSize [v3]

2024-06-17 Thread Albert Mingkun Yang
On Mon, 17 Jun 2024 14:30:30 GMT, Albert Mingkun Yang wrote: >> Obsolete OldSize and related code. An internal variable `OldSize` is kept to >> capture the capacity of old-gen size. > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The inc

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-17 Thread Albert Mingkun Yang
On Fri, 14 Jun 2024 10:19:47 GMT, Albert Mingkun Yang wrote: >> Obsolete OldSize and related code. An internal variable `OldSize` is kept to >> capture the capacity of old-gen size. > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The pul

Re: RFR: 8333962: Obsolete OldSize [v3]

2024-06-17 Thread Albert Mingkun Yang
> Obsolete OldSize and related code. An internal variable `OldSize` is kept to > capture the capacity of old-gen size. Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merg

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-17 Thread Zhengyu Gu
On Fri, 14 Jun 2024 10:19:47 GMT, Albert Mingkun Yang wrote: >> Obsolete OldSize and related code. An internal variable `OldSize` is kept to >> capture the capacity of old-gen size. > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The pul

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-17 Thread Albert Mingkun Yang
On Mon, 17 Jun 2024 13:25:00 GMT, Zhengyu Gu wrote: >> Albert Mingkun Yang has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains one commit: >> >> obsolete-old-size > > src/hotspot/share/gc/shared/genArguments.hpp line 36: > >> 34: e

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-17 Thread Zhengyu Gu
On Fri, 14 Jun 2024 10:19:47 GMT, Albert Mingkun Yang wrote: >> Obsolete OldSize and related code. An internal variable `OldSize` is kept to >> capture the capacity of old-gen size. > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The pul

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-16 Thread David Holmes
On Sat, 15 Jun 2024 08:51:56 GMT, Albert Mingkun Yang wrote: >> src/hotspot/share/runtime/arguments.cpp line 37: >> >>> 35: #include "gc/shared/gcArguments.hpp" >>> 36: #include "gc/shared/gcConfig.hpp" >>> 37: #include "gc/shared/genArguments.hpp" >> >> Why is this needed? > > `Arguments::set_

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-15 Thread Albert Mingkun Yang
On Sat, 15 Jun 2024 05:09:49 GMT, David Holmes wrote: >> Albert Mingkun Yang has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains one commit: >> >> obsolete-old-size > > src/hotspot/share/runtime/arguments.cpp line 37: > >> 35: #inc

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-14 Thread David Holmes
On Fri, 14 Jun 2024 10:19:47 GMT, Albert Mingkun Yang wrote: >> Obsolete OldSize and related code. An internal variable `OldSize` is kept to >> capture the capacity of old-gen size. > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The pul

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-14 Thread Albert Mingkun Yang
> Obsolete OldSize and related code. An internal variable `OldSize` is kept to > capture the capacity of old-gen size. Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: obsolete-old-size -

Re: RFR: 8333962: Obsolete OldSize

2024-06-13 Thread David Holmes
On Tue, 11 Jun 2024 08:17:02 GMT, Albert Mingkun Yang wrote: > Obsolete OldSize and related code. An internal variable `OldSize` is kept to > capture the capacity of old-gen size. Al seems reasonable. Thanks. src/hotspot/share/runtime/arguments.cpp line 543: > 541: { "UseNeon",

RFR: 8333962: Obsolete OldSize

2024-06-11 Thread Albert Mingkun Yang
Obsolete OldSize and related code. An internal variable `OldSize` is kept to capture the capacity of old-gen size. - Commit messages: - obsolete-old-size Changes: https://git.openjdk.org/jdk/pull/19647/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19647&range=00 Issue: